Add Separate Treatment Times for Exceeding Required Skill level #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john681611
changed the title
PabstMirror
reviewed
Jan 29, 2025
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
rautamiekka
approved these changes
Jan 29, 2025
Mike-MF
requested changes
Jan 29, 2025
|
Just my two cents, have either a setting that designates a level at which someone is skilled (eg, doctor only or medic and doctor) or split it up further so that's there's a value for doctors and one for medics |
Co-authored-by: Mike-MF <[email protected]>
Co-authored-by: Mike-MF <[email protected]>
Co-authored-by: Mike-MF <[email protected]>
Co-authored-by: Mike-MF <[email protected]>
Mike-MF
approved these changes
Jan 30, 2025
PabstMirror
reviewed
Feb 2, 2025
Co-authored-by: PabstMirror <[email protected]>
PabstMirror
approved these changes
Feb 2, 2025
rautamiekka
approved these changes
Feb 2, 2025
LinkIsGrim
reviewed
Feb 3, 2025
LinkIsGrim
reviewed
Feb 3, 2025
| @@ -30,16 +30,17 @@ if !(_this call FUNC(canTreat)) exitWith {false}; | |||
| private _config = configFile >> QGVAR(actions) >> _classname; | |||
|
|
|||
| // Get treatment time from config, exit if treatment time is zero | |||
There was a problem hiding this comment.
Personally, I'd rather a unit be considered skilled if it has required medic level for treatment + 1.
Stringtables would need to be changed to reflect this. Up to you, though.
There was a problem hiding this comment.
I may mess with this idea. But I'd rather the PR as it get in if it's not a simple implementation Turns out it was relatively easy.
PabstMirror
reviewed
Feb 3, 2025
addons/fire/compat_medical_engine/ACE_Medical_Treatment_Actions.hpp
Outdated
Show resolved
Hide resolved
…s.hpp Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
john681611
changed the title
john681611
changed the title
rautamiekka
approved these changes
Feb 3, 2025
LinkIsGrim
approved these changes
Feb 3, 2025
PabstMirror
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Add "Skilled" Variants of the treatment time setting for
"Skilled" is defined as exceeding the required skill level for treatment.
Eg If anyone can do it then skilled is Medic or Doctor
If a Medic is required, then Skilled is a Doctor
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.