Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeable and carryable flags #8943

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Conversation

Timi007
Copy link
Contributor

@Timi007 Timi007 commented Jun 21, 2022

Hello everyone, I would like to donate a component of one of my mods to ACE! Since Brett already did something like this, I took his work as a template and rewrote my component.

When merged this pull request will:

  • Add flags which can be placed or carried by a unit
    • White
    • Red
    • Blue
    • Green
    • Yellow
    • Orange
    • Purple
    • Black

flags

Co-authored-by: Jouni Järvinen <[email protected]>
Copy link
Member

@BrettMayson BrettMayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flags can be placed to hover
image

In my opinion the logisitcs of the flag pole make this seem very out of place for ACE. If the flag took more mass and could only be carried, with the flag pole being a separate item (cargo or perhaps a launcher), then maybe it could work.

Would like to hear some other opinions on this.

GVAR(actionIconCarry) = QPATHTOF(data\icons\carry\white_carry_icon.paa);

class ItemInfo: CBA_MiscItem_ItemInfo {
mass = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way too light, assault pack can carry 53 flags

@Timi007
Copy link
Contributor Author

Timi007 commented Dec 21, 2024

I made the flag pole/carrier customizable by config

@johnb432 johnb432 self-requested a review January 17, 2025 06:47
Comment on lines 65 to 66
private _jipID = [QGVAR(flagPlaced), [_player, _item, _flag]] call CBA_fnc_globalEventJIP;
[_jipID, _flag] call CBA_fnc_removeGlobalEventJIP;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of doing this to add interactions.
However, I'm not sure if using a class XEH would be better. Thoughts @LinkIsGrim ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution would be to add new vehicles for each flag and adding the pickup interaction via config. This would require more configuration but would allow placing the flags in 3DEN and Zeus.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need a map of (vehicles->flag items)
then we should be able to add a single pickup class-action on the base

I'm happy to do this if that sounds ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PabstMirror Can you please check whether the new implementation is as you envisioned it?

addons/flags/functions/fnc_getActions.sqf Outdated Show resolved Hide resolved
addons/flags/functions/fnc_getActions.sqf Outdated Show resolved Hide resolved
@PabstMirror PabstMirror added the kind/feature Release Notes: **ADDED:** label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants