-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placeable and carryable flags #8943
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Jouni Järvinen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion the logisitcs of the flag pole make this seem very out of place for ACE. If the flag took more mass and could only be carried, with the flag pole being a separate item (cargo or perhaps a launcher), then maybe it could work.
Would like to hear some other opinions on this.
addons/flags/CfgWeapons.hpp
Outdated
GVAR(actionIconCarry) = QPATHTOF(data\icons\carry\white_carry_icon.paa); | ||
|
||
class ItemInfo: CBA_MiscItem_ItemInfo { | ||
mass = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way too light, assault pack can carry 53 flags
Co-authored-by: Grim <[email protected]>
I made the flag pole/carrier customizable by config |
private _jipID = [QGVAR(flagPlaced), [_player, _item, _flag]] call CBA_fnc_globalEventJIP; | ||
[_jipID, _flag] call CBA_fnc_removeGlobalEventJIP; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of doing this to add interactions.
However, I'm not sure if using a class XEH would be better. Thoughts @LinkIsGrim ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another solution would be to add new vehicles for each flag and adding the pickup interaction via config. This would require more configuration but would allow placing the flags in 3DEN and Zeus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need a map of (vehicles->flag items)
then we should be able to add a single pickup class-action on the base
I'm happy to do this if that sounds ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PabstMirror Can you please check whether the new implementation is as you envisioned it?
Hello everyone, I would like to donate a component of one of my mods to ACE! Since Brett already did something like this, I took his work as a template and rewrote my component.
When merged this pull request will: