Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): change to read topic by polling #7400

Closed
wants to merge 24 commits into from

add missing closing parenthesis in planning.cpp

f4a3661
Select commit
Loading
Failed to load commit list.
Closed

feat(default_ad_api): change to read topic by polling #7400

add missing closing parenthesis in planning.cpp
f4a3661
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jun 10, 2024 in 42s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method autoware_state.cpp: AutowareStateNode::on_timer
  • Complex Method planning.cpp: PlanningNode::on_timer

Annotations

Check warning on line 156 in system/default_ad_api/src/planning.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

PlanningNode::on_timer increases in cyclomatic complexity from 10 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 88 in system/default_ad_api/src/compatibility/autoware_state.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

AutowareStateNode::on_timer increases in cyclomatic complexity from 17 to 20, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis