Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_departure_checker): improve LaneDepartureChecker initialization and parameter handling #9791

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Dec 25, 2024

Description

Refactors LaneDepartureChecker initialization by:

  • Removing separate setVehicleInfo and setParam calls
  • Introducing a new constructor that takes both parameters and vehicle info at initialization

Simplifies code across multiple files:

  • plot_map_case1.cpp and plot_map_case2.cpp
  • goal_planner_module.cpp
  • start_planner_module.cpp

Improves test organization in test_geometric_pull_out.cpp:

  • Extracts planner data setup into a separate method
  • Reduces code duplication
  • Removes unused member variables and imports

Related links

Parent Issue:

  • Link

How was this PR tested?

run colcon test and passed

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Dec 25, 2024
Copy link

github-actions bot commented Dec 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…sary time_keeper parameter from pull-out planners

Signed-off-by: Kyoichi Sugahara <[email protected]>
Signed-off-by: Kyoichi Sugahara <[email protected]>
…per parameter from pull-out planners

Signed-off-by: Kyoichi Sugahara <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jan 6, 2025
…lization and parameter handling

Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/lane_departure_checker/update_constructor branch from f02e3fe to 050d328 Compare January 6, 2025 06:59
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jan 6, 2025
@kyoichi-sugahara kyoichi-sugahara removed component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jan 6, 2025
…r/lane_departure_checker/update_constructor

Signed-off-by: Kyoichi Sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 5.55556% with 34 lines in your changes missing coverage. Please review.

Project coverage is 29.58%. Comparing base (ab845fb) to head (5687a1f).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...ker/src/lane_departure_checker_node/parameters.cpp 0.00% 26 Missing ⚠️
...rture_checker_node/lane_departure_checker_node.cpp 0.00% 3 Missing ⚠️
...ude/autoware/lane_departure_checker/parameters.hpp 0.00% 2 Missing ⚠️
..._start_planner_module/src/start_planner_module.cpp 0.00% 2 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9791      +/-   ##
==========================================
- Coverage   29.59%   29.58%   -0.02%     
==========================================
  Files        1451     1457       +6     
  Lines      108919   108896      -23     
  Branches    42597    42563      -34     
==========================================
- Hits        32232    32213      -19     
- Misses      73589    73593       +4     
+ Partials     3098     3090       -8     
Flag Coverage Δ *Carryforward flag
differential 28.12% <5.55%> (?)
total 29.59% <ø> (-0.01%) ⬇️ Carriedforward from 4503d30

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 485ccc6 into autowarefoundation:main Jan 10, 2025
49 of 50 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/lane_departure_checker/update_constructor branch January 10, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants