feat: impl Ease for Isometry[2/3]d
#17545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
Carter0
approved these changes
Jan 28, 2025
BenjaminBrienen
added
S-Needs-Review
greeble-dev
approved these changes
Jan 29, 2025
| #[test] | ||
| fn ease_quats() { | ||
| let quat_start = Quat::from_axis_angle(Vec3::Z, 0.0); | ||
| let quat_end = Quat::from_axis_angle(Vec3::Z, 90.0_f32.to_radians()); |
There was a problem hiding this comment.
Suggestion: instead of each case giving the angle in degrees, maybe define one angle and multiply it by the curve parameter per case?
let angle = 90.0_f32.to_radians();
let quat_end = Quat::from_axis_angle(Vec3::Z, angle);
...
assert_abs_diff_eq!(quat_curve.sample(0.5).unwrap(), Quat::from_axis_angle(Vec3::Z, 0.5 * angle));There was a problem hiding this comment.
Good point, will do!
mockersf
approved these changes
Feb 2, 2025
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - We kind of missed out on implementing the `Ease` trait for some objects like `Isometry2D` and `Isometry3D` even though it makes sense and isn't that hard - Fixes bevyengine#17539 ## Testing - wrote some minimal tests - ~~noticed that quat easing isn't working as expected yet~~ I just confused degrees and radians once again 🙈
joshua-holmes
pushed a commit
to joshua-holmes/bevy
that referenced
this pull request
Feb 5, 2025
# Objective - We kind of missed out on implementing the `Ease` trait for some objects like `Isometry2D` and `Isometry3D` even though it makes sense and isn't that hard - Fixes bevyengine#17539 ## Testing - wrote some minimal tests - ~~noticed that quat easing isn't working as expected yet~~ I just confused degrees and radians once again 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Easetrait for some objects likeIsometry2DandIsometry3Deven though it makes sense and isn't that hardEaseforIsometry3d#17539Testing
noticed that quat easing isn't working as expected yetI just confused degrees and radians once again 🙈