lenses/fstab.aug: Allow comma after the last option #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash the commits into one (you'll have to force push to your branch). Also needs a Also remove Also add |
|
@rwmjones done |
tupyy
changed the title
|
You need to add the |
|
Also it should be |
|
ptal |
|
This looks good now. I also applied it to my local tree and ran the tests and those pass. |
This PR adds a new lens that allows a comma after the last option: /dev/mapper/foo-bar / xfs defaults, 0 0 Fixes: hercules-team#832 Signed-off-by: [email protected]
rwmjones
added a commit
to rwmjones/augeas
that referenced
this pull request
Feb 4, 2025
…-team#838)" A more general fix will follow. This reverts commit 5246ef0. Signed-off-by: Richard W.M. Jones <[email protected]>
rwmjones
added a commit
to rwmjones/augeas
that referenced
this pull request
Feb 4, 2025
Mount allows mount-option fields to be empty (I think it ignores them), but augeas gave an error. Allow this to be parsed, preserving the empty option on write. Example: /dev/mapper/vg00-vartmp /var/tmp xfs rw,,nodev,nosuid,noexec,relatime 0 0 Note this generalises earlier commit 5246ef0 ("lenses/fstab.aug: Allow comma after the last option (hercules-team#838)") since "," appearing at the end of the option list is a special case of this. Fixes: https://issues.redhat.com/browse/RHEL-77279 Fixes: hercules-team#832 Signed-off-by: Richard W.M. Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new lens that allows a comma after the last option:
Fixes: #832
Signed-off-by: [email protected]