Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dockerfile + a build GHA #35

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Add a dockerfile + a build GHA #35

merged 4 commits into from
Nov 18, 2024

Conversation

yuvipanda
Copy link
Collaborator

@yuvipanda yuvipanda commented Oct 9, 2024

  • Use repo2docker-action (https://github.com/jupyterhub/repo2docker-action) for familiar (to 2i2c) tagging behavior
  • Use python images as base, rather than micromamba because I could not get the micromamba image to work.
  • Push to quay.io, now that the repo is public (rather than a private GCP Artifact Registry)

Ref 2i2c-org/frx-challenges#107

@yuvipanda yuvipanda marked this pull request as ready for review October 10, 2024 14:55
- Use repo2docker-action (https://github.com/jupyterhub/repo2docker-action)
  for familiar (to 2i2c) tagging behavior
- Use python images as base, rather than micromamba because I
  could not get the micromamba image to work

Ref 2i2c-org/frx-challenges#107
@yuvipanda
Copy link
Collaborator Author

This is ready to go, and I've populated secrets accordingly. Since @rhoadesScholar has requested a review from @mzouink, I'll wait for that :)

@rhoadesScholar rhoadesScholar self-requested a review November 18, 2024 21:47
@rhoadesScholar rhoadesScholar merged commit ab3dba3 into main Nov 18, 2024
1 check passed
@rhoadesScholar rhoadesScholar deleted the gh-docker branch November 18, 2024 21:47
yuvipanda added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants