-
Notifications
You must be signed in to change notification settings - Fork 38
Comparing changes
Open a pull request
base repository: pinecone-io/pinecone-ts-client
base: 3.0.2
head repository: pinecone-io/pinecone-ts-client
compare: main
Commits on Aug 27, 2024
-
Update README to no longer mention runtime checks (#256)
## Problem Since we removed runtime checks, we need to remove the part in our README about the `PINECONE_DISABLE_RUNTIME_VALIDATIONS` env var (missed 1st time around): https://github.com/pinecone-io/pinecone-ts-client/pull/249/files#diff-a54261af011358e447a9f3ef717ee8e5d5bb4258f8d95e246b39cf3666244f1fL275 <img width="1274" alt="Screenshot 2024-08-26 at 5 23 35 PM" src="https://github.com/user-attachments/assets/cad55314-47a6-4236-a16c-afeb436e2ed3"> ## Solution Remove it :) ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [x] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for ba64732 - Browse repository at this point
Copy the full SHA ba64732View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad9a551 - Browse repository at this point
Copy the full SHA ad9a551View commit details -
Add new Github action that deploys sample Vercel app (#257)
## Problem As part of a larger effort to set up e2e testing for different runtimes, we'd like to implement a new Github action that would run on PRs that spins up [a sample Vercel app](https://github.com/pinecone-io/pinecone-rag-demo/tree/main) that runs in the Edge runtime. ## Solution Upload this action as a test. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan CI passes
Configuration menu - View commit details
-
Copy full SHA for 08100f2 - Browse repository at this point
Copy the full SHA 08100f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d55b8b - Browse repository at this point
Copy the full SHA 4d55b8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d300a71 - Browse repository at this point
Copy the full SHA d300a71View commit details -
Configuration menu - View commit details
-
Copy full SHA for df2bf2b - Browse repository at this point
Copy the full SHA df2bf2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6b2847 - Browse repository at this point
Copy the full SHA b6b2847View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f78b43 - Browse repository at this point
Copy the full SHA 6f78b43View commit details -
Configuration menu - View commit details
-
Copy full SHA for efdb602 - Browse repository at this point
Copy the full SHA efdb602View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdac360 - Browse repository at this point
Copy the full SHA cdac360View commit details -
Modify end-to-end testing action file to use secrets correctly (#258)
## Problem Current action.yml file for the end to end testing workflow is getting the following error: > /home/runner/work/pinecone-ts-client/pinecone-ts-client/./.github/actions/e2e-testing/edge/action.yml (Line: 20, Col: 25): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.VERCEL_TOKEN ## Solution Cleaned up some parts of the action. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for e4700d6 - Browse repository at this point
Copy the full SHA e4700d6View commit details -
Move secrets only to workflow and not action file (#259)
## Problem The end to end testing workflow was getting errors related to secrets, e.g.: > /home/runner/work/pinecone-ts-client/pinecone-ts-client/./.github/actions/e2e-testing/edge/action.yml (Line: 20, Col: 25): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.VERCEL_TOKEN After reading this thread https://github.com/orgs/community/discussions/27054#discussioncomment-3254450 it seems that `secrets` might only be available in workflows and not actions. So, I've moved `secrets` to only be in the workflow file and the references to them to be in `inputs` in the `action.yml` file. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 0909d3f - Browse repository at this point
Copy the full SHA 0909d3fView commit details -
Move secrets in workflow file to
with
block (#260)## Problem The last end to end testing workflow run failed due to `inputs` being unrecognized: > [Run end-to-end tests](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10587412603/job/29338090995#step:4:1) /home/runner/work/pinecone-ts-client/pinecone-ts-client/./.github/actions/e2e-testing/edge/action.yml (Line: 34, Col: 25): Unrecognized named-value: 'inputs'. Located at position 1 within expression: inputs.VERCEL_TOKEN ## Solution ChatGPT let me know that I should actually put my `secrets` into a `with` block in my workflow file instead. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for a8e46e8 - Browse repository at this point
Copy the full SHA a8e46e8View commit details -
Convert action to a composite action (#261)
## Problem Since I'm trying to build a custom action with multiple steps, it seems that I should've formatted my action.yml file to be a "composite" action. This PR does that. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 554958d - Browse repository at this point
Copy the full SHA 554958dView commit details -
Add shell explicitly to run commands in action.yml (#262)
## Problem Apparently the `run` command needs `shell` to be explicitly below. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 9182e27 - Browse repository at this point
Copy the full SHA 9182e27View commit details
Commits on Aug 28, 2024
-
Add env vars to deploy section (#263)
## Problem Forgot to explicitly put `shell: bash` for 1 npm command + needed to move env vars down to `run` command that actually needs them. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 44a81a9 - Browse repository at this point
Copy the full SHA 44a81a9View commit details -
Setup-vercel repo having issues so change version to @master (#264)
## Problem The `amondnet/vercel-action@25` seems not to work, but [users are saying](amondnet/vercel-action#40 (comment)) change it to `@master` works. So, trying that! ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for ad6c25a - Browse repository at this point
Copy the full SHA ad6c25aView commit details -
Change vercel action path in action.yml (#265)
## Problem Vercel action is having issues, so need to change path according to this thread amondnet/vercel-action#40 (comment) ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for a952088 - Browse repository at this point
Copy the full SHA a952088View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a5eaca - Browse repository at this point
Copy the full SHA 2a5eacaView commit details -
Update naming of Vercel token + add vercel.json (#267)
## Problem The latest test run of the new e2e Edge testing CI failed with the following error: > Error: Input required and not supplied: vercel-token at Object.getInput (/home/runner/work/_actions/amondnet/vercel-action/master/dist/index.js:212:15) at /home/runner/work/_actions/amondnet/vercel-action/master/dist/index.js:32582:26 at /home/runner/work/_actions/amondnet/vercel-action/master/dist/index.js:32991:3 at Object.<anonymous> (/home/runner/work/_actions/amondnet/vercel-action/master/dist/index.js:32994:12) at Module._compile (node:internal/modules/cjs/loader:1358:14) at Module._extensions..js (node:internal/modules/cjs/loader:1416:10) at Module.load (node:internal/modules/cjs/loader:[120](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10588113496/job/29340074646#step:4:133)8:32) at Module._load (node:internal/modules/cjs/loader:1024:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12) at node:internal/main/run_main_module:28:49 The first solve I think might resolve this error is to change the naming of the Vercel token from `VERCEL_TOKEN` to `vercel-token`, as it is in the example yamls in [the Vercel GH action's repo](https://github.com/amondnet/vercel-action?tab=readme-ov-file#method-2---via-verceljson). I also noticed while reading the Vercel GH action's repo that I didn't add a `vercel.json` file, which seemingly is needed to properly deploy a Vercel project via GH actions. So, this PR adds that as well. Info about `vercel.json` here: https://vercel.com/docs/projects/project-configuration#functions. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 541c818 - Browse repository at this point
Copy the full SHA 541c818View commit details -
Change location of env vars from
with
toenv
in workflow file (#269)## Problem The [last test of the e2e Edge GH workflow file](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10602204562/job/29383732233) at the `Run e2e tests for edge runtime` step in the workflow file because it still couldn't find the `vercel-token` environment variable. ## Solution I think me having the env vars in the `with` section instead of the `env` section is causing the error, so this PR moves them. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 88ec5de - Browse repository at this point
Copy the full SHA 88ec5deView commit details -
Add necessary env vars in both
with
andenv
sections of workflow ……and action files (#270) ## Problem The previous e2e Edge GH workflow run failed due to not being able to find the `vercel-token` environment variable. From what I read, everything was set up correctly, but since it's still failing, I'm putting all environment in both the `with` and `env` sections of in both the action and workflow files. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for df692ce - Browse repository at this point
Copy the full SHA df692ceView commit details -
Remove
with
section ofDeploy to Vercel
step in action.yml file (#……271) ## Problem The last e2d Edge CI run [failed](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10602446618/job/29384504189#step:4:3) seemingly because my use of the `with` section made the pipeline think I was trying to use a prebuilt action, which I am not. ## Solution Remove `with` section and solely rely on `env` section for `Deploy to Vercel` step. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 2a20691 - Browse repository at this point
Copy the full SHA 2a20691View commit details -
Add installCommand to vercel.json to ensure package.json deps are ins…
…talled (#272) ## Problem The latest e2e Edge CI run tried to deploy the intended app to Vercel, but failed to find a `NextJS` version installed. I believe we have to install this via adding a `installCommand` field to the `vercel.json` we create in the action. ## Solution Add `installCommand` field. This should install all deps within the project dir outlined in `package.json`. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 52ac7e7 - Browse repository at this point
Copy the full SHA 52ac7e7View commit details -
Add NextJS install step (#273)
## Problem The [most recent](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10602693291) e2e Edge workflow run failed because it still couldn't find `NextJS`. <img width="1280" alt="Screenshot 2024-08-28 at 11 58 38 AM" src="https://github.com/user-attachments/assets/d681c35b-6655-4599-8f07-2b20d9b673d2"> ## Solution I removed the `includeFiles` section in order to avoid limiting Vercel's project scope in any unintended way + added an explicitly `npm install` step that installs `NextJS` globally. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for c8a5a33 - Browse repository at this point
Copy the full SHA c8a5a33View commit details -
add specific edge-runtime versionm (#274)
## Problem The [latest e2e Edge workflow run](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10602830879) failed. <img width="1246" alt="Screenshot 2024-08-28 at 12 16 43 PM" src="https://github.com/user-attachments/assets/ff4e98c4-eec9-431d-89de-eec3fb2b0364"> I tried deploying again with my same `vercel.json` file declared in the workflow, but locally, and I got the following error: <img width="733" alt="Screenshot 2024-08-28 at 12 15 08 PM" src="https://github.com/user-attachments/assets/b959b302-fa13-4849-8f87-1e87f394bcf1"> Upon declaring a specific `edge-runtime` version in `vercel.json`, I was able to deploy locally. ## Solution Try the same approach but in CI. Hoping maybe being unable to find a `NextJS` version was a red herring error, since it was uncorroborated by me after running locally. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for b6a7892 - Browse repository at this point
Copy the full SHA b6a7892View commit details -
Add logging to e2e workflow file (#275)
## Problem It's unclear to me why the workflow [still cannot find an installed version of NextJS](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10602830879/job/29385769964). ## Solution Add logging to workflow and action files. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for c3a4779 - Browse repository at this point
Copy the full SHA c3a4779View commit details -
Remove instances of using run and uses in the same step (#276)
## Problem One cannot use `run` and `uses` in the same step when making GH actions. ## Solution Remove `run` when `uses` is present. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 0396a2a - Browse repository at this point
Copy the full SHA 0396a2aView commit details -
Add npm install step to e2e action (#277)
## Problem The l[atest e2e Edge workflow](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10604556881) run failed at `npm run build` because it couldn't find some `types` declared in `tsconfig`, it seems. <img width="956" alt="Screenshot 2024-08-28 at 2 24 05 PM" src="https://github.com/user-attachments/assets/3c3aa14f-211a-4b2e-8d84-18b08d383dcf"> It looks like the action doesn't actually run `npm install` when in the root dir, so that's likely the culprit. ## Solution Add `npm install` step. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 00b826a - Browse repository at this point
Copy the full SHA 00b826aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 515e9e3 - Browse repository at this point
Copy the full SHA 515e9e3View commit details
Commits on Aug 30, 2024
-
Remove old jest-skipped-reporter module (#268)
## Problem When running `npm audit`, we had cascading vulnerabilities ranging in severity due to our use of the `jest-skipped-reporter` [module](https://github.com/rickhanlonii/jest-skipped-reporter). This module hasn't been updated in 5 years, so we really shouldn't be depending on it. ## Solution Remove this module. It only reported skipped tests, which I don't think is super necessary anyways. ## Npm Audit Results Before (recreated by checking out `main`): <img width="1388" alt="Screenshot 2024-08-28 at 11 13 50 AM" src="https://github.com/user-attachments/assets/76abc278-ee7d-49a2-8723-dfd5215a7671"> <img width="1387" alt="Screenshot 2024-08-28 at 11 13 55 AM" src="https://github.com/user-attachments/assets/a780d15a-dc39-4403-a7e5-7ee9c65bc867"> After (ran on this PR's branch): <img width="620" alt="Screenshot 2024-08-28 at 11 13 20 AM" src="https://github.com/user-attachments/assets/35a5500b-ede5-4a96-a8f9-d733381db40b"> ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [x] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan CI passes. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208058866322097
Configuration menu - View commit details
-
Copy full SHA for 768cee0 - Browse repository at this point
Copy the full SHA 768cee0View commit details -
Add final, working Vercel app e2e Edge GH workflow (#278)
## Problem Setting the necessary Pinecone-related environment variables in the Vercel UI enabled us to finalize the e2e Edge GH workflow pipeline. Everything now deploys and is workable in the `preview` environment (all we need for right now). Final working preview: https://vercel.com/pinecone-io/pinecone-rag-demo/G6hqB1w2fdNyLbHhdjqYvx7pgVzo ## Solution Pass Pinecone-related env vars needed by app through Vercel UI/dashboard. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [x] Non-code change (docs, etc) - [ ] None of the above: (explain here) --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208153851794098
Configuration menu - View commit details
-
Copy full SHA for 2930bcf - Browse repository at this point
Copy the full SHA 2930bcfView commit details -
Update cleanupResources workflow to check for deletionProtection (#279)
## Problem Currently, the `cleanupResources` script [fails](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/10623637432/job/29452705669?pr=278) to delete some indexes that spin up during our integration test suite because some of these indexes have `deletionProtection` `enabled`. ## Solution Check for `deletionProtection` being `enabled`; if it is, set it to `disabled`. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan CI passes --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208192096733434 - https://app.asana.com/0/0/1208186698556887
Configuration menu - View commit details
-
Copy full SHA for eec04fb - Browse repository at this point
Copy the full SHA eec04fbView commit details
Commits on Sep 11, 2024
-
Remove extra logging from getFetch() (#280)
## Problem getFetch() contained an extra log statement which is executed every time the API is used. ## Solution Remove the log ## Type of Change - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan Ran code that accessed and interacted with Pinecone (fetched index, queried vectors)
Configuration menu - View commit details
-
Copy full SHA for 399803e - Browse repository at this point
Copy the full SHA 399803eView commit details -
[skip ci] Publish release v3.0.3
aulorbe committedSep 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 655979f - Browse repository at this point
Copy the full SHA 655979fView commit details
Commits on Sep 12, 2024
-
Add example of proxying (#281)
## Problem The community has requested clearer direction regarding using proxy servers and other http-related customizations with our Typescript client. Asana ticket https://app.asana.com/0/1203260648987893/1205491455268495/f ## Solution Add proxying section to README + clarify some code comments. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [x] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan Describe specific steps for validating this change. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1205491455268495
Configuration menu - View commit details
-
Copy full SHA for 8324f12 - Browse repository at this point
Copy the full SHA 8324f12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73d98b8 - Browse repository at this point
Copy the full SHA 73d98b8View commit details
Commits on Sep 25, 2024
-
Change language around records --> vectors where appropriate (#288)
## Problem We believe it's more accurate to refer to dense-vector objects as "vectors" (vs "records") when we are talking about vectors we'd like to upsert into an index, etc. This is because they are primarily (first and foremost) _vectors_, with IDs, metadata, etc. ## Solution Change instances of "record(s)" to "vector(s)" where appropriate. Note: I opted _not_ to change instances of "record(s)" in cases where we are talking about the entire object as a whole (as in, "Update a record", since you could be updating the metadata, the vector values, etc.). ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [x] Non-code change (docs, etc) - [ ] None of the above: (explain here) --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208381566824289
Configuration menu - View commit details
-
Copy full SHA for 9dcd99e - Browse repository at this point
Copy the full SHA 9dcd99eView commit details
Commits on Sep 26, 2024
-
Perform housekeeping on RC Github worfklow (#289)
## Problem On [a recent RC release run](https://github.com/pinecone-io/pinecone-ts-client/actions/runs/11018817395), we ran into warnings about the variable `nameRc`. We also noticed that the current RC Github workflow automatically labels the RC build as the `latest` version on `npm` by way of not specifying a `--tag`. ## Solution This PR changes `nameRc` to `rc_name` and adds a `--tag=RC` to the `npm publish` step, so that all RC builds have an `RC` tag, instead of latest. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208381566824292 - https://app.asana.com/0/0/1208381566824295
Configuration menu - View commit details
-
Copy full SHA for c2b24c8 - Browse repository at this point
Copy the full SHA c2b24c8View commit details
Commits on Oct 7, 2024
-
Quick update to README re:
list
endpoint (#293)## Problem It's often unclear to users that the `list` endpoint (i.e. query by vector ID) does not necessarily return the vector that matches the passed ID. ## Solution Clarify that. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [x] Non-code change (docs, etc) - [ ] None of the above: (explain here) --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208439494339495
Configuration menu - View commit details
-
Copy full SHA for 03de66c - Browse repository at this point
Copy the full SHA 03de66cView commit details
Commits on Oct 14, 2024
-
Centralize test indexes for integration tests (#291)
## TLDR This PR takes our integration test timing in CI down from ~37mins to ~10mins! 🎉 ## Problem Our integration tests are currently very flakey (meaning they fail in an non-deterministic manner depending largely on fluctuations in latency on backend operations). ## Solution Centralize the creation and deletion of indexes for integration tests; cleanup the tests where I can. **The tests that now use the centralized indexes:** **- Control:** - `describeIndex.test.ts` - `listIndexes.test.ts` **- Data:** - `fetch.test.ts` - `list.test.ts` - `query.test.ts` **The tests that still have to create/delete their own indexes because their operations are difficult to undo:** **- Control:** - `configureIndex.test.ts` - `createIndex.test.ts` **- Data:** - `delete.test.ts` - `upsertAndUpdate.test.ts` ### New jobs & files - I added a job in `testing.yml` called `setup` that calls a file called `setup.ts` (`src/integration/setup.ts`) - I added a job in `testing.yml` called `teardown` that calls a file called `teardown.ts` (`src/integration/teardown.ts`) - `setup.ts` sets up (creates and seeds) a shared serverless index (only serverless for now b/c we don't have pod-based data plane tests). **The index name is randomized, so simultaneous jobs can occur using the same Pinecone API key** 😄 . - I have put a `todo` in this file to refactor it; right now, it's quite rudimentary in the way it loops and checks conditions; you'll notice other `todo`s in other files that point to where we need more tests, etc. I'd like to keep these in there for now, if that's okay. - `teardown.ts` deletes this index - I found some tests that were not actually testing what they intended to, so I have marked those as skipped for now (e.g. `createIndex.test.ts > `test('insufficient quota')`) - I added a file called `integrationRunner.js`, which is a file for running integration tests locally with a new command in `package.json` that you can execute by running `npm run test:integration-local:node`. This will do the setup, tests, and teardown all in 1 go for you locally. ### Bug fixes - Last week, @austin-denoble and I noticed a bug in `waitUntilReady` where the `status` sometimes evaluated to `Ready` without the index actually being ready. So, this PR includes a fix to that function that also checks for `state.ready` being `true` _and_ adds a value (that it also checks for) to the `IndexModelStatusStateEnum` that accounts for an index's state being `Upgrading`, which accounted for a lot of flakiness in the configureIndex tests. ## Notes - The goal of this PR is to _decrease_ flakiness - I removed one of our Bun versions to try to get the time down a bit; we might want to experiment with upping the `max-parallel` field too in `testing.yml` (although I tried removing it altogether and we had failures) - I _removed_ the job in `testing.yml` that calls `utils/cleanupResources.ts`, since I replaced it with my `Teardown` job. This file (`cleanupResources`) is still called via cron, though, by `testing-cleanup.yml` - I decided _not_ to use [jest's `globalSetup` and `globalTeardown` capabilities](https://jestjs.io/docs/configuration#globalsetup-string) because the "global" scope is per option in our test matrix. Creating a custom setup and teardown job instead allowed me to create a single test index we can use across all options in our matrix, which is more efficient. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan CI passes consistently --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208439494339500 - https://app.asana.com/0/0/1207545518662985
Configuration menu - View commit details
-
Copy full SHA for 760a033 - Browse repository at this point
Copy the full SHA 760a033View commit details
Commits on Oct 23, 2024
-
Add new generated code + new generation script for 2024-10 RC (#283)
This PR cuts a branch that holds the new generated code for the upcoming `2024-10` release candidate. It also contains changes to the generation script that reflect the new organization in the private `apis` repo. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 8c1a209 - Browse repository at this point
Copy the full SHA 8c1a209View commit details -
We currently do not have Bulk Import support in the 2024-10 RC branch. Add it in! Notes: - Bulk Import product team is still working on some final tweaks the API (e.g. `integration` --> `integration_id`), so it's likely there will be follow up PRs to this PR once those are finalized - "" will work on decreasing latency; once that is done, we can build more integration tests (right now, it takes upwards of 15 mins for vectors from a bulk import operation to show up in an index, so building integration tests in CI isn't sustainable) - I added a `featureFlag` similar to what @jhamon did in Python - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) New unit tests & integration tests pass in CI.
Configuration menu - View commit details
-
Copy full SHA for 94f1a7b - Browse repository at this point
Copy the full SHA 94f1a7bView commit details -
This PR adds the new [rerank endpoint](https://docs.pinecone.io/guides/inference/rerank) into the TS client. Note, README reflects addition. - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) CI passes. Added new unit & integration tests. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208242198563722
Configuration menu - View commit details
-
Copy full SHA for 02f4ef9 - Browse repository at this point
Copy the full SHA 02f4ef9View commit details -
Allow users to pass customField to /rerank endpoint (#303)
## Problem The current implementation of `/rerank` in the TS client does not (correctly) allow users to pass a custom field upon which to rerank. ## Solution Allow custom fields! Please reference this PR to account for all expected functionality: https://github.com/pinecone-io/python-plugin-inference/pull/21/files ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan CI passes + reviewer xreferences PR above w/functionality introduced in this PR. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208523729730914 --------- Co-authored-by: Jesse Seldess <j_seldess@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4e655d3 - Browse repository at this point
Copy the full SHA 4e655d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f27db40 - Browse repository at this point
Copy the full SHA f27db40View commit details -
[skip ci] Publish release v4.0.0
aulorbe committedOct 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 156b8e5 - Browse repository at this point
Copy the full SHA 156b8e5View commit details
Commits on Oct 29, 2024
-
Add integration testing w/external NextJS app (Edge runtime) (#304)
## Problem We do not currently have a good way to test how our client behaves end to end in different environments. One of the chief problems our users have brought to our attention in the past is that some functionalities do not work in certain runtimes, e.g. Edge or Bun, and/or with certain frameworks, e.g. [NextJS](https://nextjs.org/docs). ## Solution Build an external application in a runtime and framework known to have caused problems in the past and test our client from the end-user's perspective. This PR introduces and end-to-end test suite that interacts with an external application written using the NextJS framework and the [Edge](https://vercel.com/docs/functions/edge-middleware/edge-runtime#edge-runtime) runtime. Note: the app is automagically run in `Edge` by way of it using [middleware](https://nextjs.org/docs/app/building-your-application/routing/middleware) (`middleware.ts`), and the [`Headers()` API](https://developer.mozilla.org/en-US/docs/Web/API/Headers). ## Overview of changes - We now have [a public repo](https://github.com/pinecone-io/ts-client-e2e-tests) that contains a super simple application that builds a Pinecone serverless index, seeds it with data, and queries that data. We plan to add more operations in the near future; this is just a start. - This sample application creates an API endpoint that our client repo can send a POST request to and assert on the response. If the endpoint fails to deliver the expected response, we know that something is wrong with the most recent changes we are proposing to introduce in the client. - This PR enables 2 types of interaction with the sample application: - Local end-to-end tests: for local runs, there is a new bash script that devs can execute. This will spin up the application on their `localhost:3000`. - CI end-to-end tests: for CI runs, we will now run this test automatically by way of adding it the `testing.yml` file that is run for each push to an open PR. In CI, the Github workflow and action hit the application's Vercel endpoint and assert on its response. - There is a new CONTRIBUTING.md file with some info on this new test suite + the other existing ones, as well as a new README in the `external-app` dir itself with more in depth information. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update - [x] Infrastructure change (CI configs, etc) - [x] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan If reviewers can pull down the code in this branch and try to run the tests locally, that'd be great. ## To Dos I'll add a README and a CONTRIBUTING file to [the external app](https://github.com/pinecone-io/ts-client-e2e-tests) --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208129226784956
Configuration menu - View commit details
-
Copy full SHA for d31d6da - Browse repository at this point
Copy the full SHA d31d6daView commit details
Commits on Oct 31, 2024
-
Rename previously-named
e2e
workflow toexternal-app
for consiste……ncy (#311) ## Problem This is a fast-follow from [the PR that introduced the external app testing for Edge runtimes](#304). We just need to rename the GH workflow to match the rest of the files/code in the client, which we couldn't do previously w/o creating a new workflow and merging it to `main`. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here)
Configuration menu - View commit details
-
Copy full SHA for 621384f - Browse repository at this point
Copy the full SHA 621384fView commit details
Commits on Nov 1, 2024
-
Remove extra call to delete an already-deleted index in
bulkImport
……integration test (#313) ## Problem We kept getting errors in CI that part of the `bulkImport` integration test was failing because it could not find the given index name. ## Solution Turns out, we accidentally left in an extra call to `delete` after we had already deleted the index! This PR just removes that call :) ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan CI passes w/flying colors 🚀 --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208633891828391
Configuration menu - View commit details
-
Copy full SHA for 26d31d7 - Browse repository at this point
Copy the full SHA 26d31d7View commit details
There are no files selected for viewing