scylla-overview: Add SCT test support #2406
Conversation
k0machi
force-pushed
the
add-sct-metrics
branch
4 times, most recently
from
6a21130 to
c00b166
Compare
|
Putting the entire JSON dump inside a template file defeats the purpose of a template file. |
This is a work in progress to place sct related panels inside the overview dashboard. This is an example of how to generate the dashboard for 6.1 release: ./generate-dashboards.sh -F -v 6.1 -P "sct-tests" Signed-off-by: Amnon Heiman <[email protected]>
This commit adds SCT metrics onto the Overview dashboard, migrating them from the old dump stored in the SCT repo and instead putting them into the template with optional "sct_tests" dashproduct flag, allowing them to be conditionally added to the dashboard. Task: scylladb/qa-tasks#1444
k0machi
force-pushed
the
add-sct-metrics
branch
from
c00b166 to
0bd79bf
Compare
|
Still somewhat of a WIP but metrics have been ported: |
k0machi
changed the title
k0machi
force-pushed
the
add-sct-metrics
branch
from
779c697 to
8257cdb
Compare
Removed duplicate metrics available on other dashboards and also adjusted the layout and some of the panels unit/type configuration
k0machi
force-pushed
the
add-sct-metrics
branch
from
8257cdb to
ccab335
Compare
| "title": "Requests Served per [[by]]", | ||
| "type": "timeseries" | ||
| }, | ||
| { |
There was a problem hiding this comment.
I prefer to move this part to types.json i.e. create a new class for annotation list
| "interval": "15s", | ||
| "intervalFactor": 1, | ||
| "legendFormat": "YCSB READ [{{instance}}]", | ||
| "refId": "G" |
There was a problem hiding this comment.
why the frefid not starting from A?
|
The PR includes formatting over the entire document. It first combines tabs and spaces, and even without them, you should do it in a different patch. Besides the specific type that will be best put in types.json, as it's a lot of rows that are only relevant to QA, you can define the the few rows inside types.json so the amount of unrelated code inside the overview file will be limited (look at small_stats_row for a reference) |
This commit adds SCT metrics onto the Overview dashboard, migrating them
from the old dump stored in the SCT repo and instead putting them into
the template with optional "sct_tests" dashproduct flag, allowing them
to be conditionally added to the dashboard.
Task: https://github.com/scylladb/qa-tasks/issues/1444
Closes #2419