Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpplint): include what you use #9558

Closed
wants to merge 4 commits into from
Closed

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 3, 2024

Description

Fixes most of:

Related links

How was this PR tested?

I've generated this PR with the following script and its instructions:

fix_includes_pre-commit.py

cd autoware/src/universe/autoware.universe/
pre-commit update
wget https://gist.githubusercontent.com/xmfcx/dfd64f9e69fba1a083ad8391f5133a48/raw/18f56fdb1300daf4bf88b47b15b81505cb6e00df/fix_includes_pre-commit.py
python3 fix_includes_pre-commit.py

This should add all the missing includes.

Then you can run pre-commit run clang-format -a a couple of times to fix their orders.

Finally to verify, run: pre-commit run -a and you shouldn't have any "include-what-you-use" errors left. ✅

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) tag:require-cuda-build-and-test labels Dec 3, 2024
@xmfcx xmfcx force-pushed the fix/include-what-u-use branch from a413285 to 2ad7eb7 Compare December 3, 2024 19:24
@xmfcx xmfcx force-pushed the fix/include-what-u-use branch from b4d6f33 to 416d8ea Compare December 3, 2024 19:57
@xmfcx xmfcx self-assigned this Dec 3, 2024
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 3, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 3, 2024

Now we need to decide what to do with this mega PR.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 276 lines in your changes missing coverage. Please review.

Project coverage is 29.97%. Comparing base (de90e59) to head (416d8ea).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
perception/autoware_bytetrack/lib/src/utils.cpp 0.00% 179 Missing ⚠️
...eption/autoware_bytetrack/lib/src/byte_tracker.cpp 0.00% 97 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9558      +/-   ##
==========================================
+ Coverage   29.51%   29.97%   +0.45%     
==========================================
  Files        1445     1445              
  Lines      108532   128925   +20393     
  Branches    41382    53765   +12383     
==========================================
+ Hits        32036    38639    +6603     
- Misses      73287    85949   +12662     
- Partials     3209     4337    +1128     
Flag Coverage Δ *Carryforward flag
differential 29.91% <0.00%> (?)
total 29.58% <ø> (+0.07%) ⬆️ Carriedforward from de90e59

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 5, 2024

This was split into all the PRs above and merged through them.

@xmfcx xmfcx closed this Dec 5, 2024
@xmfcx xmfcx deleted the fix/include-what-u-use branch December 7, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant